Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eafb9eea authored by John Ogness's avatar John Ogness Committed by Greg Kroah-Hartman
Browse files

serial: 8250: move rx_running out of the bitfield



That bitfield is modified by read + or + write operation. If someone
sets any of the other two bits it might render the lock useless.

While at it, remove other bitfields as well to avoid more such
errors.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohn Ogness <john.ogness@linutronix.de>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 830acf9e
Loading
Loading
Loading
Loading
+3 −3
Original line number Diff line number Diff line
@@ -42,9 +42,9 @@ struct uart_8250_dma {
	size_t			rx_size;
	size_t			tx_size;

	unsigned char		tx_running:1;
	unsigned char		tx_err: 1;
	unsigned char		rx_running:1;
	unsigned char		tx_running;
	unsigned char		tx_err;
	unsigned char		rx_running;
};

struct old_serial_port {