Commit eac81736 authored Aug 04, 2009 by Wei Yongjun Committed by J. Bruce Fields Aug 25, 2009

sunrpc: reply AUTH_BADCRED to RPCSEC_GSS with unknown service



When an RPC message is received with RPCSEC_GSS with an unknown service
(not RPC_GSS_SVC_NONE, RPC_GSS_SVC_INTEGRITY, or RPC_GSS_SVC_PRIVACY),
svcauth_gss_accept() returns AUTH_BADCRED, but svcauth_gss_release()
subsequently drops the response entirely, discarding the error.

Fix that so the AUTH_BADCRED error is returned to the client.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

parent ed2d8aed

net/sunrpc/auth_gss/svcauth_gss.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1374,8 +1374,10 @@ svcauth_gss_release(struct svc_rqst *rqstp)
		if (stat)
		goto out_err;
		break;
		default:
		goto out_err;
		/*
		* For any other gc_svc value, svcauth_gss_accept() already set
		* the auth_error appropriately; just fall through:
		*/
		}

		out: