Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eab30949 authored by Stephen Boyd's avatar Stephen Boyd Committed by Ingo Molnar
Browse files

memblock: Document memblock_is_region_{memory,reserved}() 



At first glance one would think that memblock_is_region_memory()
and memblock_is_region_reserved() would be implemented in the
same way. Unfortunately they aren't and the former returns
whether the region specified is a subset of a memory bank while
the latter returns whether the region specified intersects with
reserved memory.

Document the two functions so that users aren't tempted to
make the implementation the same between them and to clarify the
purpose of the functions.

Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Cc: Tejun Heo <tj@kernel.org>
Link: http://lkml.kernel.org/r/1337845521-32755-1-git-send-email-sboyd@codeaurora.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 8a173b14

mm/memblock.c

+20 −0
Original line number Diff line number Diff line
@@ -867,6 +867,16 @@ int __init_memblock memblock_is_memory(phys_addr_t addr) 
	return memblock_search(&memblock.memory, addr) != -1;

}



/**

 * memblock_is_region_memory - check if a region is a subset of memory

 * @base: base of region to check

 * @size: size of region to check

 *

 * Check if the region [@base, @base+@size) is a subset of a memory block.

 *

 * RETURNS:

 * 0 if false, non-zero if true

 */

int __init_memblock memblock_is_region_memory(phys_addr_t base, phys_addr_t size)

{

	int idx = memblock_search(&memblock.memory, base);
@@ -879,6 +889,16 @@ int __init_memblock memblock_is_region_memory(phys_addr_t base, phys_addr_t size 
		 memblock.memory.regions[idx].size) >= end;

}



/**

 * memblock_is_region_reserved - check if a region intersects reserved memory

 * @base: base of region to check

 * @size: size of region to check

 *

 * Check if the region [@base, @base+@size) intersects a reserved memory block.

 *

 * RETURNS:

 * 0 if false, non-zero if true

 */

int __init_memblock memblock_is_region_reserved(phys_addr_t base, phys_addr_t size)

{

	memblock_cap_size(base, &size);