Commit ea237a6a authored Feb 06, 2008 by Julia Lawall Committed by Linus Torvalds Feb 06, 2008

drivers/video: remove unnecessary pci_dev_put



pci_get_class implicitly does a pci_dev_put on its second argument, so
pci_dev_put is only needed if there is a break out of the loop.

The semantic match detecting this problem is as follows:

// <smpl>
@@
expression dev;
expression E;
@@

* pci_dev_put(dev)
  ... when != dev = E
(
* pci_get_device(...,dev)
|
* pci_get_device_reverse(...,dev)
|
* pci_get_subsys(...,dev)
|
* pci_get_class(...,dev)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 5a1c84f1

drivers/video/sis/sis_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4621,9 +4621,9 @@ sisfb_find_host_bridge(struct sis_video_info ivideo, struct pci_dev mypdev,

		while((pdev = pci_get_class(PCI_CLASS_BRIDGE_HOST, pdev))) {
		temp = pdev->vendor;
		pci_dev_put(pdev);
		if(temp == pcivendor) {
		ret = 1;
		pci_dev_put(pdev);
		break;
		}
		}