Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9daf2ad authored by Nishanth Aravamudan's avatar Nishanth Aravamudan Committed by Benjamin Herrenschmidt
Browse files

powerpc/prom: Remove limit on maximum size of properties 



On a 16TB system (using AMS/CMO), I get:

WARNING: ignoring large property [/ibm,dynamic-reconfiguration-memory] ibm,dynamic-memory length 0x000000000017ffec

and significantly less memory is thus shown to the partition. As far as
I can tell, the constant used is arbitrary. Ben Herrenschmidt provided
additional background that

> The limit was originally set because of Apple machines carrying ROM
> images in the device-tree, at a time where we were much more memory
> constrained than we are now.

and that it is likely not very useful any longer.

Signed-off-by: default avatarNishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent a2007ce8

arch/powerpc/kernel/prom_init.c

+0 −15
Original line number Original line Diff line number Diff line
@@ -47,14 +47,6 @@ 




#include <linux/linux_logo.h>

#include <linux/linux_logo.h>





/*

 * Properties whose value is longer than this get excluded from our

 * copy of the device tree. This value does need to be big enough to

 * ensure that we don't lose things like the interrupt-map property

 * on a PCI-PCI bridge.

 */

#define MAX_PROPERTY_LENGTH	(1UL * 1024 * 1024)



/*

/*

 * Eventually bump that one up

 * Eventually bump that one up

 */

 */
@@ -2273,13 +2265,6 @@ static void __init scan_dt_build_struct(phandle node, unsigned long *mem_start, 
		/* sanity checks */

		/* sanity checks */

		if (l == PROM_ERROR)

		if (l == PROM_ERROR)

			continue;

			continue;

		if (l > MAX_PROPERTY_LENGTH) {

			prom_printf("WARNING: ignoring large property ");

			/* It seems OF doesn't null-terminate the path :-( */

			prom_printf("[%s] ", path);

			prom_printf("%s length 0x%x\n", RELOC(pname), l);

			continue;

		}





		/* push property head */

		/* push property head */

		dt_push_token(OF_DT_PROP, mem_start, mem_end);

		dt_push_token(OF_DT_PROP, mem_start, mem_end);