Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9d7dc62 authored by Dave Airlie's avatar Dave Airlie Committed by Alex Deucher
Browse files

amdgpu/dc: don't check for 0 on register read/writes always. 



This adds ~50k to the driver text segment, and 10k to data segment.

   text	   data	    bss	    dec	    hex	filename
2385556	  39681	   1045	2426282	 2505aa	drivers/gpu/drm/amd/amdgpu/amdgpu.o
  text	   data	    bss	    dec	    hex	filename
2336593	  28857	   1045	2366495	 241c1f	drivers/gpu/drm/amd/amdgpu/amdgpu.o

Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 5e0adbff

drivers/gpu/drm/amd/display/dc/dm_services.h

+7 −2
Original line number Diff line number Diff line
@@ -96,6 +96,9 @@ irq_handler_idx dm_register_interrupt( 
 *

 */



/* enable for debugging new code, this adds 50k to the driver size. */

/* #define DM_CHECK_ADDR_0 */



#define dm_read_reg(ctx, address)	\

		dm_read_reg_func(ctx, address, __func__)
@@ -105,12 +108,12 @@ static inline uint32_t dm_read_reg_func( 
	const char *func_name)

{

	uint32_t value;



#ifdef DM_CHECK_ADDR_0

	if (address == 0) {

		DC_ERR("invalid register read; address = 0\n");

		return 0;

	}



#endif

	value = cgs_read_register(ctx->cgs_device, address);



	return value;
@@ -125,10 +128,12 @@ static inline void dm_write_reg_func( 
	uint32_t value,

	const char *func_name)

{

#ifdef DM_CHECK_ADDR_0

	if (address == 0) {

		DC_ERR("invalid register write. address = 0");

		return;

	}

#endif

	cgs_write_register(ctx->cgs_device, address, value);

}