Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9b13740 authored by James Simmons's avatar James Simmons Committed by Greg Kroah-Hartman
Browse files

staging: lustre: llite: cleanup xattr code comments 



Add proper punctuation to the comments. Change buf_size to size
for comment in ll_listxattr() since buf_size doesn't exit which
will confuse someone reading the code.

Signed-off-by: default avatarJames Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183
Reviewed-on: https://review.whamcloud.com/27240


Reviewed-by: default avatarDmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: default avatarBob Glossman <bob.glossman@intel.com>
Reviewed-by: default avatarSebastien Buisson <sbuisson@ddn.com>
Reviewed-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarJames Simmons <jsimmons@infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d04bd562

drivers/staging/lustre/lustre/llite/xattr.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -564,7 +564,7 @@ ssize_t ll_listxattr(struct dentry *dentry, char *buffer, size_t size) 
		return rc;

		return rc;

	/*

	/*

	 * If we're being called to get the size of the xattr list

	 * If we're being called to get the size of the xattr list

	 * (buf_size == 0) then just assume that a lustre.lov xattr

	 * (size == 0) then just assume that a lustre.lov xattr

	 * exists.

	 * exists.

	 */

	 */

	if (!size)

	if (!size)
@@ -577,14 +577,14 @@ ssize_t ll_listxattr(struct dentry *dentry, char *buffer, size_t size) 
		len = strnlen(xattr_name, rem - 1) + 1;

		len = strnlen(xattr_name, rem - 1) + 1;

		rem -= len;

		rem -= len;

		if (!xattr_type_filter(sbi, get_xattr_type(xattr_name))) {

		if (!xattr_type_filter(sbi, get_xattr_type(xattr_name))) {

			/* Skip OK xattr type leave it in buffer */

			/* Skip OK xattr type, leave it in buffer. */

			xattr_name += len;

			xattr_name += len;

			continue;

			continue;

		}

		}





		/*

		/*

		 * Move up remaining xattrs in buffer

		 * Move up remaining xattrs in buffer

		 * removing the xattr that is not OK

		 * removing the xattr that is not OK.

		 */

		 */

		memmove(xattr_name, xattr_name + len, rem);

		memmove(xattr_name, xattr_name + len, rem);

		rc -= len;

		rc -= len;