Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9990d70 authored by Colin Ian King's avatar Colin Ian King Committed by Thomas Gleixner
Browse files

irqchip/qcom: Fix u32 comparison with value less than zero 



The comparison of u32 nregs being less than zero is never true since
nregs is unsigned. Fix this by making nregs a signed integer.

Fixes: f20cc9b0 ("irqchip/qcom: Add IRQ combiner driver")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: kernel-janitors@vger.kernel.org
Cc: Jason Cooper <jason@lakedaemon.net>
Link: https://lkml.kernel.org/r/20171117183553.2739-1-colin.king@canonical.com
parent 0e54705b

drivers/irqchip/qcom-irq-combiner.c

+1 −1
Original line number Diff line number Diff line
@@ -238,7 +238,7 @@ static int __init combiner_probe(struct platform_device *pdev) 
{

	struct combiner *combiner;

	size_t alloc_sz;

	u32 nregs;

	int nregs;

	int err;



	nregs = count_registers(pdev);