Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9976151 authored by Josef Bacik's avatar Josef Bacik Committed by Chris Mason
Browse files

Btrfs: only log the inode item if we can get away with it 



Currently we copy all the file information into the log, inode item, the
refs, xattrs etc.  Except most of this doesn't change from fsync to fsync,
just the inode item changes.  So set a flag if an xattr changes or a link is
added, and otherwise only log the inode item.  Thanks,

Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
Signed-off-by: default avatarChris Mason <chris.mason@fusionio.com>
parent 5f3ab90a

fs/btrfs/btrfs_inode.h

+1 −0
Original line number Diff line number Diff line
@@ -39,6 +39,7 @@ 
#define BTRFS_INODE_HAS_ORPHAN_ITEM		5

#define BTRFS_INODE_HAS_ASYNC_EXTENT		6

#define BTRFS_INODE_NEEDS_FULL_SYNC		7

#define BTRFS_INODE_COPY_EVERYTHING		8



/* in memory btrfs inode */

struct btrfs_inode {

fs/btrfs/inode.c

+1 −0
Original line number Diff line number Diff line
@@ -5083,6 +5083,7 @@ static int btrfs_link(struct dentry *old_dentry, struct inode *dir, 
	inode_inc_iversion(inode);

	inode->i_ctime = CURRENT_TIME;

	ihold(inode);

	set_bit(BTRFS_INODE_COPY_EVERYTHING, &BTRFS_I(inode)->runtime_flags);



	err = btrfs_add_nondir(trans, dir, dentry, inode, 1, index);

fs/btrfs/tree-log.c

+8 −2
Original line number Diff line number Diff line
@@ -3429,14 +3429,20 @@ static int btrfs_log_inode(struct btrfs_trans_handle *trans, 
	} else {

		if (test_and_clear_bit(BTRFS_INODE_NEEDS_FULL_SYNC,

				       &BTRFS_I(inode)->runtime_flags)) {

			clear_bit(BTRFS_INODE_COPY_EVERYTHING,

				  &BTRFS_I(inode)->runtime_flags);

			ret = btrfs_truncate_inode_items(trans, log,

							 inode, 0, 0);

		} else {

			if (inode_only == LOG_INODE_ALL)

				fast_search = true;

			if (test_and_clear_bit(BTRFS_INODE_COPY_EVERYTHING,

					       &BTRFS_I(inode)->runtime_flags))

				max_key.type = BTRFS_XATTR_ITEM_KEY;

			else

				max_key.type = BTRFS_INODE_ITEM_KEY;

			ret = drop_objectid_items(trans, log, path, ino,

						  BTRFS_XATTR_ITEM_KEY);

						  max_key.type);

		}

	}

	if (ret) {

fs/btrfs/xattr.c

+1 −0
Original line number Diff line number Diff line
@@ -208,6 +208,7 @@ int __btrfs_setxattr(struct btrfs_trans_handle *trans, 


	inode_inc_iversion(inode);

	inode->i_ctime = CURRENT_TIME;

	set_bit(BTRFS_INODE_COPY_EVERYTHING, &BTRFS_I(inode)->runtime_flags);

	ret = btrfs_update_inode(trans, root, inode);

	BUG_ON(ret);

out: