Commit e9720fd2 authored Apr 09, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman Apr 11, 2013

staging: comedi: 8255: use __comedi_request_region()



Use __comedi_request_region() to request the I/O regions used by
this driver.

Remove the  error message when the request_region() fails,
comedi_request_reqion() will output the error message if necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ca8b2964

drivers/staging/comedi/drivers/8255.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -372,16 +372,13 @@ static int dev_8255_attach(struct comedi_device *dev,
		s = &dev->subdevices[i];
		iobase = it->options[i];

		if (!request_region(iobase, _8255_SIZE, "8255")) {
		dev_warn(dev->class_dev,
		"0x%04lx (I/O port conflict)\n", iobase);

		ret = __comedi_request_region(dev, iobase, _8255_SIZE);
		if (ret) {
		s->type = COMEDI_SUBD_UNUSED;
		} else {
		ret = subdev_8255_init(dev, s, NULL, iobase);
		if (ret)
		return ret;
		dev_info(dev->class_dev, "0x%04lx\n", iobase);
		}
		}