Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8a445de authored by Andy Lutomirski's avatar Andy Lutomirski Committed by Ingo Molnar
Browse files

selftests/x86/sigreturn: Do minor cleanups 



We have short names for the requested and resulting register values.
Use them instead of spelling out the whole register entry for each
case.

Signed-off-by: default avatarAndy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/bb3bc1f923a2f6fe7912d22a1068fe29d6033d38.1530076529.git.luto@kernel.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent ec348020

tools/testing/selftests/x86/sigreturn.c

+7 −6
Original line number Diff line number Diff line
@@ -610,6 +610,7 @@ static int test_valid_sigreturn(int cs_bits, bool use_16bit_ss, int force_ss) 
	 */

	for (int i = 0; i < NGREG; i++) {

		greg_t req = requested_regs[i], res = resulting_regs[i];



		if (i == REG_TRAPNO || i == REG_IP)

			continue;	/* don't care */
@@ -673,18 +674,18 @@ static int test_valid_sigreturn(int cs_bits, bool use_16bit_ss, int force_ss) 
#endif



		/* Sanity check on the kernel */

		if (i == REG_CX && requested_regs[i] != resulting_regs[i]) {

		if (i == REG_CX && req != res) {

			printf("[FAIL]\tCX (saved SP) mismatch: requested 0x%llx; got 0x%llx\n",

			       (unsigned long long)requested_regs[i],

			       (unsigned long long)resulting_regs[i]);

			       (unsigned long long)req,

			       (unsigned long long)res);

			nerrs++;

			continue;

		}



		if (requested_regs[i] != resulting_regs[i] && !ignore_reg) {

		if (req != res && !ignore_reg) {

			printf("[FAIL]\tReg %d mismatch: requested 0x%llx; got 0x%llx\n",

			       i, (unsigned long long)requested_regs[i],

			       (unsigned long long)resulting_regs[i]);

			       i, (unsigned long long)req,

			       (unsigned long long)res);

			nerrs++;

		}

	}