Commit e882472d authored Sep 20, 2018 by Nathan Chancellor Committed by Greg Kroah-Hartman Jun 09, 2023

regulator: da905{2,5}: Remove unnecessary array check

commit 5a7d7d0f9f791b1e13f26dbbb07c86482912ad62 upstream.

Clang warns that the address of a pointer will always evaluated as true
in a boolean context:

drivers/regulator/da9052-regulator.c:423:22: warning: address of array
'pdata->regulators' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (pdata && pdata->regulators) {
                  ~~ ~~~~~~~^~~~~~~~~~
drivers/regulator/da9055-regulator.c:615:22: warning: address of array
'pdata->regulators' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (pdata && pdata->regulators) {
                  ~~ ~~~~~~~^~~~~~~~~~

Link: https://github.com/ClangBuiltLinux/linux/issues/142


Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 707aec61

drivers/regulator/da9052-regulator.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -421,7 +421,7 @@ static int da9052_regulator_probe(struct platform_device *pdev)
		config.dev = &pdev->dev;
		config.driver_data = regulator;
		config.regmap = da9052->regmap;
		if (pdata && pdata->regulators) {
		if (pdata) {
		config.init_data = pdata->regulators[cell->id];
		} else {
		#ifdef CONFIG_OF

drivers/regulator/da9055-regulator.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -612,7 +612,7 @@ static int da9055_regulator_probe(struct platform_device *pdev)
		config.driver_data = regulator;
		config.regmap = da9055->regmap;

		if (pdata && pdata->regulators) {
		if (pdata) {
		config.init_data = pdata->regulators[pdev->id];
		} else {
		ret = da9055_regulator_dt_init(pdev, regulator, &config,