Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e84f44eb authored by Jimmy Assarsson's avatar Jimmy Assarsson Committed by Marc Kleine-Budde
Browse files

can: kvaser_usb: Fix comparison bug in kvaser_usb_read_bulk_callback() 



The conditon in the while-loop becomes true when actual_length is less than
2 (MSG_HEADER_LEN). In best case we end up with a former, already
dispatched msg, that got msg->len greater than actual_length. This will
result in a "Format error" error printout.

Problem seen when unplugging a Kvaser USB device connected to a vbox guest.

warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]

Signed-off-by: default avatarJimmy Assarsson <jimmyassarsson@gmail.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 435019b4

drivers/net/can/usb/kvaser_usb.c

+1 −1
Original line number Diff line number Diff line
@@ -1334,7 +1334,7 @@ static void kvaser_usb_read_bulk_callback(struct urb *urb) 
		goto resubmit_urb;

	}



	while (pos <= urb->actual_length - MSG_HEADER_LEN) {

	while (pos <= (int)(urb->actual_length - MSG_HEADER_LEN)) {

		msg = urb->transfer_buffer + pos;



		/* The Kvaser firmware can only read and write messages that