Commit e7f4c4bf authored Jun 14, 2017 by Dan Carpenter Committed by Linus Walleij Jun 20, 2017

pinctrl: ingenic: checking for NULL instead of IS_ERR()

devm_pinctrl_register() returns error pointers, it doesn't return NULL.

Fixes: b5c23aa4 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 1bd303dc

drivers/pinctrl/pinctrl-ingenic.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -785,9 +785,9 @@ int ingenic_pinctrl_probe(struct platform_device *pdev)
		}

		jzpc->pctl = devm_pinctrl_register(dev, pctl_desc, jzpc);
		if (!jzpc->pctl) {
		if (IS_ERR(jzpc->pctl)) {
		dev_err(dev, "Failed to register pinctrl\n");
		return -EINVAL;
		return PTR_ERR(jzpc->pctl);
		}

		for (i = 0; i < chip_info->num_groups; i++) {