Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e7e11f99 authored by Li Qiang's avatar Li Qiang Committed by Thomas Hellstrom
Browse files

drm/vmwgfx: fix integer overflow in vmw_surface_define_ioctl() 



In vmw_surface_define_ioctl(), the 'num_sizes' is the sum of the
'req->mip_levels' array. This array can be assigned any value from
the user space. As both the 'num_sizes' and the array is uint32_t,
it is easy to make 'num_sizes' overflow. The later 'mip_levels' is
used as the loop count. This can lead an oob write. Add the check of
'req->mip_levels' to avoid this.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarLi Qiang <liqiang6-s@360.cn>
Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
parent 53e16798

drivers/gpu/drm/vmwgfx/vmwgfx_surface.c

+4 −1
Original line number Diff line number Diff line
@@ -713,8 +713,11 @@ int vmw_surface_define_ioctl(struct drm_device *dev, void *data, 
			128;



	num_sizes = 0;

	for (i = 0; i < DRM_VMW_MAX_SURFACE_FACES; ++i)

	for (i = 0; i < DRM_VMW_MAX_SURFACE_FACES; ++i) {

		if (req->mip_levels[i] > DRM_VMW_MAX_MIP_LEVELS)

			return -EINVAL;

		num_sizes += req->mip_levels[i];

	}



	if (num_sizes > DRM_VMW_MAX_SURFACE_FACES * DRM_VMW_MAX_MIP_LEVELS ||

	    num_sizes == 0)