Commit e6ef6a77 authored May 23, 2017 by Gustavo A. R. Silva Committed by Martin K. Petersen May 31, 2017

scsi: lpfc: prevent potential null pointer dereference



Null check at line 966: if (ndlp) {, implies that ndlp might be NULL.
Functions lpfc_nlp_set_state() and lpfc_issue_els_prli() dereference
pointer ndlp. Include these function calls inside the IF block that
tests pointer ndlp.

Addresses-Coverity-ID: 1401856
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 7c9fdfb7

drivers/scsi/lpfc/lpfc_ct.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -978,9 +978,10 @@ lpfc_cmpl_ct_cmd_gft_id(struct lpfc_hba phba, struct lpfc_iocbq cmdiocb,
		ndlp, did, ndlp->nlp_fc4_type,
		FC_TYPE_FCP, FC_TYPE_NVME);
		ndlp->nlp_prev_state = NLP_STE_REG_LOGIN_ISSUE;
		}

		lpfc_nlp_set_state(vport, ndlp, NLP_STE_PRLI_ISSUE);
		lpfc_issue_els_prli(vport, ndlp, 0);
		}
		} else
		lpfc_printf_vlog(vport, KERN_ERR, LOG_DISCOVERY,
		"3065 GFT_ID failed x%08x\n", irsp->ulpStatus);