Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6cdfcc5 authored by Parvi Kaustubhi's avatar Parvi Kaustubhi Committed by David S. Miller
Browse files

enic: reset fetch index 



Since we are allowing rx ring size modification, reset fetch index
everytime. Otherwise it could have a stale value that can lead to a null
pointer dereference.

Signed-off-by: default avatarGovindarajulu Varadarajan <gvaradar@cisco.com>
Signed-off-by: default avatarParvi Kaustubhi <pkaustub@cisco.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 59c1cecc

drivers/net/ethernet/cisco/enic/vnic_rq.c

+2 −14
Original line number Diff line number Diff line
@@ -139,19 +139,7 @@ void vnic_rq_init(struct vnic_rq *rq, unsigned int cq_index, 
	unsigned int error_interrupt_enable,

	unsigned int error_interrupt_offset)

{

	u32 fetch_index = 0;



	/* Use current fetch_index as the ring starting point */

	fetch_index = ioread32(&rq->ctrl->fetch_index);



	if (fetch_index == 0xFFFFFFFF) { /* check for hardware gone  */

		/* Hardware surprise removal: reset fetch_index */

		fetch_index = 0;

	}



	vnic_rq_init_start(rq, cq_index,

		fetch_index, fetch_index,

		error_interrupt_enable,

	vnic_rq_init_start(rq, cq_index, 0, 0, error_interrupt_enable,

			   error_interrupt_offset);

}