Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6a595d2 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter
Browse files

drm/i915: Reject page flips with changed format/offset/pitch 



MI display flips can't handle some changes in the framebuffer
format or layout. Return an error in such cases.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 3a7f2f6a

drivers/gpu/drm/i915/intel_display.c

+13 −0
Original line number Diff line number Diff line
@@ -6438,6 +6438,19 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, 
	unsigned long flags;

	int ret;



	/* Can't change pixel format via MI display flips. */

	if (fb->pixel_format != crtc->fb->pixel_format)

		return -EINVAL;



	/*

	 * TILEOFF/LINOFF registers can't be changed via MI display flips.

	 * Note that pitch changes could also affect these register.

	 */

	if (INTEL_INFO(dev)->gen > 3 &&

	    (fb->offsets[0] != crtc->fb->offsets[0] ||

	     fb->pitches[0] != crtc->fb->pitches[0]))

		return -EINVAL;



	work = kzalloc(sizeof *work, GFP_KERNEL);

	if (work == NULL)

		return -ENOMEM;