Commit e6626748 authored Apr 28, 2018 by Heiner Kallweit Committed by David S. Miller Apr 30, 2018

r8169: remove unneeded call to __rtl8169_set_features in rtl_open



RxChkSum and RxVlan aren't touched outside __rtl8169_set_features
(except in probe), so they are always in sync with dev->features.
And the RxConfig flags are set in rtl_set_rx_mode() which is
called via dev_set_rx_mode() from __dev_open().
Therefore we can safely remove this call.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 76c2a96d

drivers/net/ethernet/realtek/r8169.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -7637,8 +7637,6 @@ static int rtl_open(struct net_device *dev)

		rtl8169_init_phy(dev, tp);

		__rtl8169_set_features(dev, dev->features);

		rtl_pll_power_up(tp);

		rtl_hw_start(tp);