Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6520a3c authored by Martin Sperl's avatar Martin Sperl Committed by Mark Brown
Browse files

spi: loopback-test: write rx pattern also when running without tx_buf 



Currently the rx_buf does not get set with the
SPI_TEST_PATTERN_UNWRITTEN when tx_buf == NULL in the transfer.

Reorder code so that it gets done also under this specific condition.

Signed-off-by: default avatarMartin Sperl <kernel@martin.sperl.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 739f3e92

drivers/spi/spi-loopback-test.c

+4 −4
Original line number Diff line number Diff line
@@ -591,6 +591,10 @@ static int spi_test_fill_tx(struct spi_device *spi, struct spi_test *test) 


	/* fill all transfers with the pattern requested */

	for (i = 0; i < test->transfer_count; i++) {

		/* fill rx_buf with SPI_TEST_PATTERN_UNWRITTEN */

		if (xfers[i].rx_buf)

			memset(xfers[i].rx_buf, SPI_TEST_PATTERN_UNWRITTEN,

			       xfers[i].len);

		/* if tx_buf is NULL then skip */

		tx_buf = (u8 *)xfers[i].tx_buf;

		if (!tx_buf)
@@ -648,10 +652,6 @@ static int spi_test_fill_tx(struct spi_device *spi, struct spi_test *test) 
				return -EINVAL;

			}

		}

		/* fill rx_buf with SPI_TEST_PATTERN_UNWRITTEN */

		if (xfers[i].rx_buf)

			memset(xfers[i].rx_buf, SPI_TEST_PATTERN_UNWRITTEN,

			       xfers[i].len);

	}



	return 0;