Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5d672a0 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

rhashtable: reorganize struct rhashtable layout 



While under frags DDOS I noticed unfortunate false sharing between
@nelems and @params.automatic_shrinking

Move @nelems at the end of struct rhashtable so that first cache line
is shared between all cpus, because almost never dirtied.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 05c0b86b

include/linux/rhashtable.h

+4 −4
Original line number Diff line number Diff line
@@ -152,25 +152,25 @@ struct rhashtable_params { 
/**

 * struct rhashtable - Hash table handle

 * @tbl: Bucket table

 * @nelems: Number of elements in table

 * @key_len: Key length for hashfn

 * @p: Configuration parameters

 * @max_elems: Maximum number of elements in table

 * @p: Configuration parameters

 * @rhlist: True if this is an rhltable

 * @run_work: Deferred worker to expand/shrink asynchronously

 * @mutex: Mutex to protect current/future table swapping

 * @lock: Spin lock to protect walker list

 * @nelems: Number of elements in table

 */

struct rhashtable {

	struct bucket_table __rcu	*tbl;

	atomic_t			nelems;

	unsigned int			key_len;

	struct rhashtable_params	p;

	unsigned int			max_elems;

	struct rhashtable_params	p;

	bool				rhlist;

	struct work_struct		run_work;

	struct mutex                    mutex;

	spinlock_t			lock;

	atomic_t			nelems;

};



/**