Commit e5d2861f authored Jun 23, 2007 by Kirill Korotaev Committed by Linus Torvalds Jun 24, 2007

ext4: lost brelse in ext4_read_inode()



One of error path in ext4_read_inode() leaks bh since brelse is forgoten.

Signed-off-by: Kirill Korotaev <dev@openvz.org>
Acked-by: Vasily Averin <vvs@sw.ru>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e4a10a36

fs/ext4/inode.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2673,8 +2673,10 @@ void ext4_read_inode(struct inode * inode)
		*/
		ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize);
		if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize >
		EXT4_INODE_SIZE(inode->i_sb))
		EXT4_INODE_SIZE(inode->i_sb)) {
		brelse (bh);
		goto bad_inode;
		}
		if (ei->i_extra_isize == 0) {
		/* The extra space is currently unused. Use it. */
		ei->i_extra_isize = sizeof(struct ext4_inode) -