Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e58c5de8 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

drivers/ide/ide-cs.c: adjust suspicious bit operation 

IO_DATA_PATH_WIDTH_8 is 0, so a bit-and with it is always false.  The
value IO_DATA_PATH_WIDTH covers the bits of the IO_DATA_PATH constants, so
first pick those bits and then make the test using !=.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/

).

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 027253c1

drivers/ide/ide-cs.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -167,7 +167,8 @@ static int pcmcia_check_one_config(struct pcmcia_device *pdev, void *priv_data) 
{

{

	int *is_kme = priv_data;

	int *is_kme = priv_data;





	if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) {

	if ((pdev->resource[0]->flags & IO_DATA_PATH_WIDTH)

	    != IO_DATA_PATH_WIDTH_8) {

		pdev->resource[0]->flags &= ~IO_DATA_PATH_WIDTH;

		pdev->resource[0]->flags &= ~IO_DATA_PATH_WIDTH;

		pdev->resource[0]->flags |= IO_DATA_PATH_WIDTH_AUTO;

		pdev->resource[0]->flags |= IO_DATA_PATH_WIDTH_AUTO;

	}

	}