Commit e58c590c authored Apr 01, 2019 by YueHaibing Committed by Greg Kroah-Hartman Jan 17, 2020

dccp: Fix memleak in __feat_register_sp



commit 1d3ff0950e2b40dc861b1739029649d03f591820 upstream.

If dccp_feat_push_change fails, we forget free the mem
which is alloced by kmemdup in dccp_feat_clone_sp_val.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: e8ef967a ("dccp: Registration routines for changing feature values")
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d203ff6a

net/dccp/feat.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local,
		if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
		return -ENOMEM;

		return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
		if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
		kfree(fval.sp.vec);
		return -ENOMEM;
		}

		return 0;
		}

		/**