Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e517ef19 authored by Yi Zhang's avatar Yi Zhang Committed by Greg Kroah-Hartman
Browse files

nvme: fix the parameter order for nvme_get_log in nvme_get_fw_slot_info 



commit f25372ffc3f6c2684b57fb718219137e6ee2b64c upstream.

nvme fw-activate operation will get bellow warning log,
fix it by update the parameter order

[  113.231513] nvme nvme0: Get FW SLOT INFO log error

Fixes: 0e98719b ("nvme: simplify the API for getting log pages")
Reported-by: default avatarSujith Pandel <sujith_pandel@dell.com>
Reviewed-by: default avatarDavid Milburn <dmilburn@redhat.com>
Signed-off-by: default avatarYi Zhang <yi.zhang@redhat.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a4fc3b99

drivers/nvme/host/core.c

+1 −1
Original line number Diff line number Diff line
@@ -3449,7 +3449,7 @@ static void nvme_get_fw_slot_info(struct nvme_ctrl *ctrl) 
	if (!log)

		return;



	if (nvme_get_log(ctrl, NVME_NSID_ALL, 0, NVME_LOG_FW_SLOT, log,

	if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, log,

			sizeof(*log), 0))

		dev_warn(ctrl->device, "Get FW SLOT INFO log error\n");

	kfree(log);