Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e502ac5e authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: atm: ueagle-atm: fix up some permissions on the sysfs files 



Some of the sysfs files had the incorrect permissions.  Some didn't make
sense at all (writable for a file that you could not write to?)

Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Cc: Matthieu Castet <castet.matthieu@free.fr>
Cc: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: Damien Bergamini <damien.bergamini@free.fr>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 3cf7f0c0

drivers/usb/atm/ueagle-atm.c

+3 −4
Original line number Diff line number Diff line
@@ -2301,7 +2301,7 @@ static ssize_t reboot(struct device *dev, struct device_attribute *attr, 
	return ret;

}



static DEVICE_ATTR(stat_status, S_IWUGO | S_IRUGO, read_status, reboot);

static DEVICE_ATTR(stat_status, S_IWUSR | S_IRUGO, read_status, reboot);



static ssize_t read_human_status(struct device *dev,

			struct device_attribute *attr, char *buf)
@@ -2364,8 +2364,7 @@ static ssize_t read_human_status(struct device *dev, 
	return ret;

}



static DEVICE_ATTR(stat_human_status, S_IWUGO | S_IRUGO,

				read_human_status, NULL);

static DEVICE_ATTR(stat_human_status, S_IRUGO, read_human_status, NULL);



static ssize_t read_delin(struct device *dev, struct device_attribute *attr,

		char *buf)
@@ -2397,7 +2396,7 @@ static ssize_t read_delin(struct device *dev, struct device_attribute *attr, 
	return ret;

}



static DEVICE_ATTR(stat_delin, S_IWUGO | S_IRUGO, read_delin, NULL);

static DEVICE_ATTR(stat_delin, S_IRUGO, read_delin, NULL);



#define UEA_ATTR(name, reset)					\

								\