Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4c5d376 authored by Sagi Grimberg's avatar Sagi Grimberg
Browse files

nvme-loop: fix a possible use-after-free when destroying the admin queue 



we need to destroy the nvmet sq and let it finish gracefully
before continue to cleanup the queue.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
parent efd4b81a

drivers/nvme/target/loop.c

+1 −1
Original line number Diff line number Diff line
@@ -288,9 +288,9 @@ static struct blk_mq_ops nvme_loop_admin_mq_ops = { 


static void nvme_loop_destroy_admin_queue(struct nvme_loop_ctrl *ctrl)

{

	nvmet_sq_destroy(&ctrl->queues[0].nvme_sq);

	blk_cleanup_queue(ctrl->ctrl.admin_q);

	blk_mq_free_tag_set(&ctrl->admin_tag_set);

	nvmet_sq_destroy(&ctrl->queues[0].nvme_sq);

}



static void nvme_loop_free_ctrl(struct nvme_ctrl *nctrl)