Commit e4b11b89 authored Sep 18, 2012 by Roland Dreier Committed by Nicholas Bellinger Sep 22, 2012

qla2xxx: Fix endianness of task management response code



The qla2xxx firmware actually expects the task management response
code in a CTIO IOCB with SCSI status mode 1 to be in little-endian
byte order, ie the response code should be the first byte in the
sense_data[] array.  The old code erroneously byte-swapped the
response code, which puts it in the wrong place on the wire and leads
to initiators thinking every task management request succeeds (since
they see 0 in the byte where they look for the response code).

Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: Chad Dupuis <chad.dupuis@qlogic.com>
Cc: Arun Easi <arun.easi@qlogic.com>
Acked-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 37bb7899

drivers/scsi/qla2xxx/qla_target.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1403,7 +1403,7 @@ static void qlt_24xx_send_task_mgmt_ctio(struct scsi_qla_host *ha,
	ctio->u.status1.scsi_status =		ctio->u.status1.scsi_status =
	__constant_cpu_to_le16(SS_RESPONSE_INFO_LEN_VALID);		__constant_cpu_to_le16(SS_RESPONSE_INFO_LEN_VALID);
	ctio->u.status1.response_len = __constant_cpu_to_le16(8);		ctio->u.status1.response_len = __constant_cpu_to_le16(8);
	((uint32_t *)ctio->u.status1.sense_data)[0] = cpu_to_be32(resp_code);		ctio->u.status1.sense_data[0] = resp_code;

	qla2x00_start_iocbs(ha, ha->req);		qla2x00_start_iocbs(ha, ha->req);
	}		}