Commit e4599339 authored Sep 20, 2013 by Xenia Ragiadakou Committed by Sarah Sharp Oct 09, 2013

xhci: fix write to USB3_PSSEN and XUSB2PRM pci config registers



The function pci_write_config_dword() sets the appropriate byteordering
internally so the value argument should not be converted to little-endian.
This bug was found by sparse.

This patch is not suitable for stable.  Since cpu_to_lei32 is a no-op on
little endian systems, this bug would only affect big endian Intel
systems with the EHCI to xHCI port switchover, which are non-existent,
AFAIK.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>

parent 455f5892

drivers/usb/host/pci-quirks.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -799,7 +799,7 @@ void usb_enable_intel_xhci_ports(struct pci_dev *xhci_pdev)
		* switchable ports.
		*/
		pci_write_config_dword(xhci_pdev, USB_INTEL_USB3_PSSEN,
		cpu_to_le32(ports_available));
		ports_available);

		pci_read_config_dword(xhci_pdev, USB_INTEL_USB3_PSSEN,
		&ports_available);
		@@ -821,7 +821,7 @@ void usb_enable_intel_xhci_ports(struct pci_dev *xhci_pdev)
		* host.
		*/
		pci_write_config_dword(xhci_pdev, USB_INTEL_XUSB2PR,
		cpu_to_le32(ports_available));
		ports_available);

		pci_read_config_dword(xhci_pdev, USB_INTEL_XUSB2PR,
		&ports_available);