Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e44fabbe authored by Jesper Juhl's avatar Jesper Juhl Committed by Greg Kroah-Hartman
Browse files

usb/storage/ene_ub6250: Remove redundant NULL check before release_firmware()... 


usb/storage/ene_ub6250: Remove redundant NULL check before release_firmware() and pointless assignment

release_firmware() tests for a NULL pointer, so it's redundant to do
that checking before calling it.

Additionally, in ene_load_bincode(), 'sd_fw' is a local variable so
setting it to NULL just before it goes out of scope is completely
pointless, so remove that assignment.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c6fa0b4c

drivers/usb/storage/ene_ub6250.c

+1 −5
Original line number Diff line number Diff line
@@ -1933,11 +1933,7 @@ static int ene_load_bincode(struct us_data *us, unsigned char flag) 
	kfree(buf);



nofw:

	if (sd_fw != NULL) {

	release_firmware(sd_fw);

		sd_fw = NULL;

	}



	return result;

}