Commit e3d5092b authored Mar 22, 2017 by Joerg Roedel Committed by Rafael J. Wysocki Mar 28, 2017

ACPI: ioapic: Clear on-stack resource before using it



The on-stack resource-window 'win' in setup_res() is not
properly initialized. This causes the pointers in the
embedded 'struct resource' to contain stale addresses.

These pointers (in my case the ->child pointer) later get
propagated to the global iomem_resources list, causing a #GP
exception when the list is traversed in
iomem_map_sanity_check().

Fixes: c183619b (x86/irq, ACPI: Implement ACPI driver to support IOAPIC hotplug)
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent c02ed2e7

drivers/acpi/ioapic.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -45,6 +45,12 @@ static acpi_status setup_res(struct acpi_resource acpi_res, void data)
		struct resource *res = data;
		struct resource_win win;

		/*
		* We might assign this to 'res' later, make sure all pointers are
		* cleared before the resource is added to the global list
		*/
		memset(&win, 0, sizeof(win));

		res->flags = 0;
		if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM))
		return AE_OK;