Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e29129fc authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

net: dsa: mv88e6xxx: missing unlock on error path 



We added a new error path, but we need to drop the lock before we return.

Fixes: 2d2e1dd2 ("net: dsa: mv88e6xxx: Cache the port cmode")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f6f7a26a

drivers/net/dsa/mv88e6xxx/chip.c

+1 −1
Original line number Diff line number Diff line
@@ -2408,7 +2408,7 @@ static int mv88e6xxx_setup(struct dsa_switch *ds) 
		if (chip->info->ops->port_get_cmode) {

			err = chip->info->ops->port_get_cmode(chip, i, &cmode);

			if (err)

				return err;

				goto unlock;



			chip->ports[i].cmode = cmode;

		}