Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e26ed44c authored by Afzal Mohammed's avatar Afzal Mohammed Committed by Tomi Valkeinen
Browse files

OMAP: DSS2: OMAPFB: Fix probe error path 



Move sysfs entry creation to omapfb_probe() from omapfb_create_framebuffers().
This will make sure that sysfs entry is not left behind in case of unsuccessful
probe due to failure in enabling fb0 of omapfb_create_framebuffers().

Signed-off-by: default avatarAfzal Mohammed <lazfamam@gmail.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@nokia.com>
parent f3fe53c1

drivers/video/omap2/omapfb/omapfb-main.c

+7 −7
Original line number Diff line number Diff line
@@ -2005,13 +2005,6 @@ static int omapfb_create_framebuffers(struct omapfb2_device *fbdev) 
		}

	}



	DBG("create sysfs for fbs\n");

	r = omapfb_create_sysfs(fbdev);

	if (r) {

		dev_err(fbdev->dev, "failed to create sysfs entries\n");

		return r;

	}



	/* Enable fb0 */

	if (fbdev->num_fbs > 0) {

		struct omapfb_info *ofbi = FB2OFB(fbdev->fbs[0]);
@@ -2297,6 +2290,13 @@ static int omapfb_probe(struct platform_device *pdev) 
		}

	}



	DBG("create sysfs for fbs\n");

	r = omapfb_create_sysfs(fbdev);

	if (r) {

		dev_err(fbdev->dev, "failed to create sysfs entries\n");

		goto cleanup;

	}



	return 0;



cleanup: