Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e22cdcfa authored by Marek Vasut's avatar Marek Vasut Committed by Herbert Xu
Browse files

crypto: caam - Kill SPRINTFCAT() with fire



This macro is just like an encyclopedia of string handling done wrong.
This must die. This is so wrong on so many levels.

Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Horia Geanta <horia.geanta@freescale.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 4f0fa52a
Loading
Loading
Loading
Loading
+0 −10
Original line number Diff line number Diff line
@@ -158,16 +158,6 @@ static const char * const rng_err_id_list[] = {
	"Secure key generation",
};

#define SPRINTFCAT(str, format, param, max_alloc)		\
{								\
	char *tmp;						\
								\
	tmp = kmalloc(sizeof(format) + max_alloc, GFP_ATOMIC);	\
	sprintf(tmp, format, param);				\
	strcat(str, tmp);					\
	kfree(tmp);						\
}

static void report_ccb_status(struct device *jrdev, u32 status,
			      const char *error, char *__outstr)
{