Commit e1a96fb8 authored May 21, 2015 by Axel Lin Committed by Thomas Gleixner May 22, 2015

irqchip: mtk-sysirq: Make mtk_sysirq_of_init return error if ioremap fails



PTR_ERR(NULL) returns 0 so current code returns 0 if ioremap fails, fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: linux-mediatek@lists.infradead.org <linux-mediatek@lists.infradead.org>
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/1432220254.29544.1.camel@ingics.com


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent a6c761e4

drivers/irqchip/irq-mtk-sysirq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -144,7 +144,7 @@ static int __init mtk_sysirq_of_init(struct device_node *node,
		chip_data->intpol_base = ioremap(res.start, size);
		if (!chip_data->intpol_base) {
		pr_err("mtk_sysirq: unable to map sysirq register\n");
		ret = PTR_ERR(chip_data->intpol_base);
		ret = -ENXIO;
		goto out_free;
		}