Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e0f41456 authored Oct 13, 2017 by Stephen Boyd Committed by Rob Herring Oct 16, 2017

of: unittest: Remove redundant OF_DETACHED flag setting



of_fdt_unflatten_tree() already sets the flag on the node to
OF_DETACHED, because of_fdt_unflatten_tree() calls
__unflatten_device_tree() with the detached bool set to true.

Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>

parent f5d2da67

drivers/of/unittest.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -993,7 +993,6 @@ static int __init unittest_data_add(void)
		pr_warn("%s: No tree to attach; not running tests\n", __func__);
		return -ENODATA;
		}
		of_node_set_flag(unittest_data_node, OF_DETACHED);
		rc = of_resolve_phandles(unittest_data_node);
		if (rc) {
		pr_err("%s: Failed to resolve phandles (rc=%i)\n", __func__, rc);
		@@ -2143,7 +2142,6 @@ static int __init overlay_data_add(int onum)
		ret = 0;
		goto out_free_data;
		}
		of_node_set_flag(info->np_overlay, OF_DETACHED);

		ret = of_resolve_phandles(info->np_overlay);
		if (ret) {