Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e0d0ae8a authored by Amitkumar Karwar's avatar Amitkumar Karwar Committed by Kalle Valo
Browse files

rsi: use BUILD_BUG_ON check for fsm_state 



Whenever new fsm_state enum element is added, fsm_state array
also needs to be updated. If this change is missed, we may end
up doing invalid access in array. BUILD_BUG_ON check will help
to avoid this problem.

Signed-off-by: default avatarAmitkumar Karwar <amit.karwar@redpinesignals.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 1283c617

drivers/net/wireless/rsi/rsi_91x_debugfs.c

+2 −0
Original line number Diff line number Diff line
@@ -138,6 +138,8 @@ static int rsi_stats_read(struct seq_file *seq, void *data) 
	seq_puts(seq, "==> RSI STA DRIVER STATUS <==\n");

	seq_puts(seq, "DRIVER_FSM_STATE: ");



	BUILD_BUG_ON(ARRAY_SIZE(fsm_state) != NUM_FSM_STATES);



	if (common->fsm_state <= FSM_MAC_INIT_DONE)

		seq_printf(seq, "%s", fsm_state[common->fsm_state]);

drivers/net/wireless/rsi/rsi_main.h

+3 −1
Original line number Diff line number Diff line
@@ -40,7 +40,9 @@ enum RSI_FSM_STATES { 
	FSM_RESET_MAC_SENT,

	FSM_RADIO_CAPS_SENT,

	FSM_BB_RF_PROG_SENT,

	FSM_MAC_INIT_DONE

	FSM_MAC_INIT_DONE,



	NUM_FSM_STATES

};



extern u32 rsi_zone_enabled;