Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e007ce9c authored by Eric Biggers's avatar Eric Biggers Committed by David Howells
Browse files

KEYS: use kmemdup() in request_key_auth_new() 



kmemdup() is preferred to kmalloc() followed by memcpy().

Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent 4aa68e07

security/keys/request_key_auth.c

+2 −3
Original line number Diff line number Diff line
@@ -163,9 +163,10 @@ struct key *request_key_auth_new(struct key *target, const void *callout_info, 
	rka = kzalloc(sizeof(*rka), GFP_KERNEL);

	if (!rka)

		goto error;

	rka->callout_info = kmalloc(callout_len, GFP_KERNEL);

	rka->callout_info = kmemdup(callout_info, callout_len, GFP_KERNEL);

	if (!rka->callout_info)

		goto error_free_rka;

	rka->callout_len = callout_len;



	/* see if the calling process is already servicing the key request of

	 * another process */
@@ -196,8 +197,6 @@ struct key *request_key_auth_new(struct key *target, const void *callout_info, 


	rka->target_key = key_get(target);

	rka->dest_keyring = key_get(dest_keyring);

	memcpy(rka->callout_info, callout_info, callout_len);

	rka->callout_len = callout_len;



	/* allocate the auth key */

	sprintf(desc, "%x", target->serial);