Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dfa73065 authored by Kieran Bingham's avatar Kieran Bingham Committed by Archit Taneja
Browse files

drm: bridge: dw-hdmi: Remove unused function parameter 



The 'prep' parameter passed to hdmi_phy_configure() is useless. It is
hardcoded as 0, and if set, simply prevents the configure function from
executing.

Remove it.

Signed-off-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: default avatarJose Abreu <joabreu@synopsys.com>
Signed-off-by: default avatarArchit Taneja <architt@codeaurora.org>
Link: http://patchwork.freedesktop.org/patch/msgid/20170117082910.27023-4-laurent.pinchart+renesas@ideasonboard.com
parent ecaa98f1

drivers/gpu/drm/bridge/dw-hdmi.c

+2 −5
Original line number Diff line number Diff line
@@ -931,7 +931,7 @@ static void dw_hdmi_phy_sel_interface_control(struct dw_hdmi *hdmi, u8 enable) 
			 HDMI_PHY_CONF0_SELDIPIF_MASK);

}



static int hdmi_phy_configure(struct dw_hdmi *hdmi, unsigned char prep,

static int hdmi_phy_configure(struct dw_hdmi *hdmi,

			      unsigned char res, int cscon)

{

	unsigned res_idx;
@@ -941,9 +941,6 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, unsigned char prep, 
	const struct dw_hdmi_curr_ctrl *curr_ctrl = pdata->cur_ctr;

	const struct dw_hdmi_phy_config *phy_config = pdata->phy_config;



	if (prep)

		return -EINVAL;



	switch (res) {

	case 0:	/* color resolution 0 is 8 bit colour depth */

	case 8:
@@ -1072,7 +1069,7 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi) 
		dw_hdmi_phy_enable_powerdown(hdmi, true);



		/* Enable CSC */

		ret = hdmi_phy_configure(hdmi, 0, 8, cscon);

		ret = hdmi_phy_configure(hdmi, 8, cscon);

		if (ret)

			return ret;

	}