Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df4f6e8c authored by Corentin Labbe's avatar Corentin Labbe Committed by Thierry Reding
Browse files

pwm: sunxi: Use of_device_get_match_data() 



The usage of of_device_get_match_data reduce the code size a bit.
Furthermore, it prevents an improbable dereference when
of_match_device() returns NULL.

Signed-off-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 1b3d9a93

drivers/pwm/pwm-sun4i.c

+4 −4
Original line number Diff line number Diff line
@@ -368,14 +368,15 @@ static int sun4i_pwm_probe(struct platform_device *pdev) 
	struct sun4i_pwm_chip *pwm;

	struct resource *res;

	int ret;

	const struct of_device_id *match;



	match = of_match_device(sun4i_pwm_dt_ids, &pdev->dev);



	pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL);

	if (!pwm)

		return -ENOMEM;



	pwm->data = of_device_get_match_data(&pdev->dev);

	if (!pwm->data)

		return -ENODEV;



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	pwm->base = devm_ioremap_resource(&pdev->dev, res);

	if (IS_ERR(pwm->base))
@@ -385,7 +386,6 @@ static int sun4i_pwm_probe(struct platform_device *pdev) 
	if (IS_ERR(pwm->clk))

		return PTR_ERR(pwm->clk);



	pwm->data = match->data;

	pwm->chip.dev = &pdev->dev;

	pwm->chip.ops = &sun4i_pwm_ops;

	pwm->chip.base = -1;