Commit df427cac authored Dec 26, 2018 by Wen Yang Committed by Greg Kroah-Hartman Dec 05, 2019

net/wan/fsl_ucc_hdlc: Avoid double free in ucc_hdlc_probe()



[ Upstream commit 40752b3eae29f8ca2378e978a02bd6dbeeb06d16 ]

This patch fixes potential double frees if register_hdlc_device() fails.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Reviewed-by: Peng Hao <peng.hao2@zte.com.cn>
CC: Zhao Qiang <qiang.zhao@nxp.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: netdev@vger.kernel.org
CC: linuxppc-dev@lists.ozlabs.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e3a5ee13

drivers/net/wan/fsl_ucc_hdlc.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1113,7 +1113,6 @@ static int ucc_hdlc_probe(struct platform_device *pdev)
		if (register_hdlc_device(dev)) {
		ret = -ENOBUFS;
		pr_err("ucc_hdlc: unable to register hdlc device\n");
		free_netdev(dev);
		goto free_dev;
		}