Commit df3fe8de authored Sep 30, 2006 by Corey Minyard Committed by Linus Torvalds Oct 01, 2006

[PATCH] ipmi: don't start kipmid if the IPMI driver can use interrupts



If the driver has interrupts available to it, there is really no reason to
have a kernel daemon push the IPMI state machine.

Note that I have experienced machines where the interrupts do not work
correctly.  This was a long time ago and hopefully things are better now.
If some machines still have broken interrupts, a blacklist will need to be
added.

Signed-off-by: Corey Minyard <minyard@acm.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent dcb9c392

drivers/char/ipmi/ipmi_si_intf.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -916,7 +916,11 @@ static int smi_start_processing(void *send_info,
		new_smi->last_timeout_jiffies = jiffies;
		mod_timer(&new_smi->si_timer, jiffies + SI_TIMEOUT_JIFFIES);

		if (new_smi->si_type != SI_BT) {
		/*
		* The BT interface is efficient enough to not need a thread,
		* and there is no need for a thread if we have interrupts.
		*/
		if ((new_smi->si_type != SI_BT) && (!new_smi->irq)) {
		new_smi->thread = kthread_run(ipmi_thread, new_smi,
		"kipmi%d", new_smi->intf_num);
		if (IS_ERR(new_smi->thread)) {