Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df2d7981 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Paul Mundt
Browse files

hgafb: use display information in info not in var for panning 



We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>
Cc: Brent Cook <busterb@gmail.com>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent ff55fe9a

drivers/video/hgafb.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -422,8 +422,8 @@ static int hgafb_pan_display(struct fb_var_screeninfo *var, 
		    var->xoffset)

		    var->xoffset)

			return -EINVAL;

			return -EINVAL;

	} else {

	} else {

		if (var->xoffset + var->xres > info->var.xres_virtual

		if (var->xoffset + info->var.xres > info->var.xres_virtual

		 || var->yoffset + var->yres > info->var.yres_virtual

		 || var->yoffset + info->var.yres > info->var.yres_virtual

		 || var->yoffset % 8)

		 || var->yoffset % 8)

			return -EINVAL;

			return -EINVAL;

	}

	}