Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dee0586e authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

sd: fix an error return in probe() 



If device_add() fails then it should return the error code but instead
the current code returns success.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarTomas Henzl <thenzl@redhat.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent ef10b169

drivers/scsi/sd.c

+2 −1
Original line number Diff line number Diff line
@@ -2988,7 +2988,8 @@ static int sd_probe(struct device *dev) 
	sdkp->dev.class = &sd_disk_class;

	dev_set_name(&sdkp->dev, "%s", dev_name(dev));



	if (device_add(&sdkp->dev))

	error = device_add(&sdkp->dev);

	if (error)

		goto out_free_index;



	get_device(dev);