Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de281f7e authored by Peter Rosin's avatar Peter Rosin Committed by Mauro Carvalho Chehab
Browse files

media: saa7146: fix error return from master_xfer 



Returning -1 (-EPERM) is not appropriate here, go with -EIO.

Signed-off-by: default avatarPeter Rosin <peda@axentia.se>
Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 2f533709

drivers/media/common/saa7146/saa7146_i2c.c

+2 −2
Original line number Diff line number Diff line
@@ -308,7 +308,7 @@ static int saa7146_i2c_transfer(struct saa7146_dev *dev, const struct i2c_msg *m 
	/* prepare the message(s), get number of u32s to transfer */

	count = saa7146_i2c_msg_prepare(msgs, num, buffer);

	if ( 0 > count ) {

		err = -1;

		err = -EIO;

		goto out;

	}
@@ -360,7 +360,7 @@ static int saa7146_i2c_transfer(struct saa7146_dev *dev, const struct i2c_msg *m 
	/* if any things had to be read, get the results */

	if ( 0 != saa7146_i2c_msg_cleanup(msgs, num, buffer)) {

		DEB_I2C("could not cleanup i2c-message\n");

		err = -1;

		err = -EIO;

		goto out;

	}