Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de117312 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Bartlomiej Zolnierkiewicz
Browse files

video: fbdev: aty: radeon_pm: Replace mdelay with msleep in radeonfb_pci_suspend 



radeonfb_pci_suspend() is never called in atomic context.

radeonfb_pci_suspend() is only set as ".suspend" in struct pci_driver.
This function is not called in atomic context.

Despite never getting called from atomic context, radeonfb_pci_suspend()
calls mdelay() to busily wait.
This is not necessary and can be replaced with msleep() 
and usleep_range() to avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent 86c4e7c3

drivers/video/fbdev/aty/radeon_pm.c

+4 −4
Original line number Diff line number Diff line
@@ -2678,17 +2678,17 @@ int radeonfb_pci_suspend(struct pci_dev *pdev, pm_message_t mesg) 
		 * it, we'll restore the dynamic clocks state on wakeup

		 */

		radeon_pm_disable_dynamic_mode(rinfo);

		mdelay(50);

		msleep(50);

		radeon_pm_save_regs(rinfo, 1);



		if (rinfo->is_mobility && !(rinfo->pm_mode & radeon_pm_d2)) {

			/* Switch off LVDS interface */

			mdelay(1);

			usleep_range(1000, 2000);

			OUTREG(LVDS_GEN_CNTL, INREG(LVDS_GEN_CNTL) & ~(LVDS_BL_MOD_EN));

			mdelay(1);

			usleep_range(1000, 2000);

			OUTREG(LVDS_GEN_CNTL, INREG(LVDS_GEN_CNTL) & ~(LVDS_EN | LVDS_ON));

			OUTREG(LVDS_PLL_CNTL, (INREG(LVDS_PLL_CNTL) & ~30000) | 0x20000);

			mdelay(20);

			msleep(20);

			OUTREG(LVDS_GEN_CNTL, INREG(LVDS_GEN_CNTL) & ~(LVDS_DIGON));

		}

		pci_disable_device(pdev);