Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de0fa83c authored by Julia Lawall's avatar Julia Lawall Committed by Mark Brown
Browse files

spi/spi-{bcm63xx.c,bfin-v3.c}: simplify use of devm_ioremap_resource 

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

Move the call to platform_get_resource adjacent to the call to
devm_ioremap_resource to make the connection between them more clear.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent fa4bd4f1

drivers/spi/spi-bcm63xx.c

+1 −7
Original line number Diff line number Diff line
@@ -360,13 +360,6 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) 
	struct bcm63xx_spi *bs;

	int ret;



	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!r) {

		dev_err(dev, "no iomem\n");

		ret = -ENXIO;

		goto out;

	}



	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(dev, "no irq\n");
@@ -393,6 +386,7 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, master);

	bs->pdev = pdev;



	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	bs->regs = devm_ioremap_resource(&pdev->dev, r);

	if (IS_ERR(bs->regs)) {

		ret = PTR_ERR(bs->regs);

drivers/spi/spi-bfin-v3.c

+1 −7
Original line number Diff line number Diff line
@@ -792,13 +792,6 @@ static int bfin_spi_probe(struct platform_device *pdev) 
		return -ENXIO;

	}



	/* get register base and tx/rx dma */

	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!mem) {

		dev_err(dev, "can not get register base\n");

		return -ENXIO;

	}



	res = platform_get_resource(pdev, IORESOURCE_DMA, 0);

	if (!res) {

		dev_err(dev, "can not get tx dma resource\n");
@@ -838,6 +831,7 @@ static int bfin_spi_probe(struct platform_device *pdev) 
	drv_data->pin_req = info->pin_req;

	drv_data->sclk = sclk;



	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	drv_data->regs = devm_ioremap_resource(dev, mem);

	if (IS_ERR(drv_data->regs)) {

		ret = PTR_ERR(drv_data->regs);