Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dda49922 authored by Mayank Rana's avatar Mayank Rana Committed by Hemant Kumar
Browse files

dwc3: core: Disable dwc3 IRQ explicitly with dwc3_probe() API 



Commit 04c848d3 ("genirq: Warn when IRQ_NOAUTOEN is used with shared
interrupts") added WARN_ON() when driver is requesting shared IRQ after
setting IRQ_NOAUTOEN flag. USB controller interrupt is shared IRQ and
controller driver does use IRQ_NOAUTOEN flag before requesting irq. This
results into WARN_ON() with dwc3_probe(). Fix WARN_ON() by using
disable_irq() explicitly instead of setting IRQ_NOAUTOEN flag.

Change-Id: I1d166d04d724ef0f3cce322dbe80398f51bf894f
Signed-off-by: default avatarMayank Rana <mrana@codeaurora.org>
Signed-off-by: default avatarHemant Kumar <hemantk@codeaurora.org>
parent b39f3fd2

drivers/usb/dwc3/core.c

+2 −2
Original line number Diff line number Diff line
@@ -1264,8 +1264,6 @@ static int dwc3_probe(struct platform_device *pdev) 


	irq = platform_get_irq(to_platform_device(dwc->dev), 0);



	/* will be enabled in dwc3_msm_resume() */

	irq_set_status_flags(irq, IRQ_NOAUTOEN);

	ret = devm_request_irq(dev, irq, dwc3_interrupt, IRQF_SHARED, "dwc3",

			dwc);

	if (ret) {
@@ -1274,6 +1272,8 @@ static int dwc3_probe(struct platform_device *pdev) 
		return -ENODEV;

	}



	/* will be enabled in dwc3_msm_resume() */

	disable_irq(irq);

	dwc->irq = irq;

	/*

	 * Request memory region but exclude xHCI regs,