Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd92d5ea authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Jonathan Cameron
Browse files

iio: multiplexer: add NULL check on devm_kzalloc() and devm_kmemdup() return values 



Check return values from call to devm_kzalloc() and devm_kmemup()
in order to prevent a NULL pointer dereference.

This issue was detected using Coccinelle and the following semantic patch:

@@
expression x;
identifier fld;
@@

* x = devm_kzalloc(...);
   ... when != x == NULL
   x->fld

Fixes: 7ba9df54 ("iio: multiplexer: new iio category and iio-mux driver")
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: default avatarPeter Rosin <peda@axentia.se>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 9d2f715d

drivers/iio/multiplexer/iio-mux.c

+6 −0
Original line number Diff line number Diff line
@@ -284,6 +284,9 @@ static int mux_configure_channel(struct device *dev, struct mux *mux, 
	child->ext_info_cache = devm_kzalloc(dev,

					     sizeof(*child->ext_info_cache) *

					     num_ext_info, GFP_KERNEL);

	if (!child->ext_info_cache)

		return -ENOMEM;



	for (i = 0; i < num_ext_info; ++i) {

		child->ext_info_cache[i].size = -1;
@@ -308,6 +311,9 @@ static int mux_configure_channel(struct device *dev, struct mux *mux, 


		child->ext_info_cache[i].data = devm_kmemdup(dev, page, ret + 1,

							     GFP_KERNEL);

		if (!child->ext_info_cache[i].data)

			return -ENOMEM;



		child->ext_info_cache[i].data[ret] = 0;

		child->ext_info_cache[i].size = ret;

	}