Commit dd85ebf6 authored Sep 10, 2015 by Sudip Mukherjee Committed by Mark Brown Sep 11, 2015

spi: spidev: fix possible NULL dereference

During the last close we are freeing spidev if spidev->spi is NULL, but
just before checking if spidev->spi is NULL we are dereferencing it.
Lets add a check there to avoid the NULL dereference.

Fixes: 91690516 ("spi: spidev: Don't mangle max_speed_hz in underlying spi device")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent bc0195aa

drivers/spi/spidev.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -651,6 +651,7 @@ static int spidev_release(struct inode inode, struct file filp)
		kfree(spidev->rx_buffer);
		spidev->rx_buffer = NULL;

		if (spidev->spi)
		spidev->speed_hz = spidev->spi->max_speed_hz;

		/* ... after we unbound from the underlying device? */